|
|
The method Question ::updateQuestionOrder() receives 3 args: gid, language, startPosition.
The database controller calls this method wrongly three times directly, passing the survey ID as second parameter (where it was supposed to be language), so those invocations have no effect, as the questions query returns no items.
At last, when moving questions in between groups (to a lower group), the database controller calls the function shiftOrderQuestions (which in turn calls updateQuestionOrder). That seems to be OK and seems to be the only point where it's required.
Should we remove those bad invocations? |
|
|
-
Removed language from Question::updateQuestionOrder parameters.
The method now uses the survey base language to work.
-
Changed how order is handled in actionUpdateQuestion (database.php)
-
Removed call to Question::updateQuestionOrder in actionInsertCopyQuestion() (database.php), because order was already handled.
-
Updated shiftOrderQuestions (common_helper.php) for not using language inside of it.
This function is not used anymore in Limesurvey's codebase, but still it might be used by others, or in the future.
-
Calls to Question::updateSortOrder where replaced by Question::updateQuestionOrder for consistency.
updateSortOrder is not removed from the codebase, just in case.
Test scenarios:
- Insert Questions
- Edit question group attribute. Move to upper group
- Edit question group attribute. Move to lower group
- Move questions from sidebar to another group
- Move questions from sidebar within the same group
- Move questions from Reorganizer
- Copy from one group to another group
- Copy within the same group
- Delete
All times, order should be checked visually, refreshing screens and also on the DB.
PR: https://github.com/LimeSurvey/LimeSurvey/pull/1532 |
