Here the lss hacked

Here the pull request:
https://github.com/LimeSurvey/LimeSurvey/pull/1280

@realitix : I'm OK to merge the issue, but maybe we can have a solution to «don't broke» for surveyid < 0 too ?

1. Add it to model rules
2. Disable loading of old survey id < 0
3. Delete it in checkintegrity ?

Hello Denis,

From what I know, it's not possible to have a SID < 0.
So my simple patch may be enough.

I'm not sure I understood your comment.

it will crash all the application.

I check what happen and see if we can automatically fix this before disable import bad lss :)

After we add the rules and other fix :)

@realitix : unsure about the solution : why not return an error : «Invalid sid in LSS» ?

It's just a quick point of view :)

Ok, can confirm, but still : i think it best if

1. Add it in rules : array('sid', 'numerical', 'integerOnly'=>true,'min'=>1),
2. Remove GetNewSurveyID function from import_helper
3. Add the control in https://github.com/LimeSurvey/LimeSurvey/blob/fb787fb08733b9747cfb83a778becb3b4835005c/application/models/Survey.php#L935

I check now after imported if we can fix it too.

Ok, broke with $baselang = $survey->language; with debug=2
broke with Call to a member function getAttributes() on null with debug = 0

checkintegrity don't fix it

Can be deleted in Survey listing Quick action : don't think need a fix for previous survey

From what I know, it's not possible to have a SID < 0.

Unsure on this point, and it broke (you make the proof).

BUt : you fix it only for LSS import, not for TSV import or copy/hack HTML to set value to -1/Remote control

Move it to Model : it's fix in more situation :)

Yes indeed, the bug is larger than I thought.
I wait for your patch since you took the issue.

I wait for your patch … i take only the responsibility to discuss and merge …

I can't assign it to you in mantis or github …

https://github.com/LimeSurvey/LimeSurvey/commit/676619f9491de9e138ebec1f43ac9297a82a6830

Next time i didn't assign me ;)

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=29014