View Issue Details

Related ChangesetsJump to NotesJump to History
This bug affects 1 person(s).
 8
IDProjectCategoryView StatusDate SubmittedLast Update
16519Bug reportsConditionspublic2020-07-22 17:152020-08-03 11:23
Reportergabrieljenik Assigned To 
PrioritynoneSeveritypartial_block 
Status closedResolutionfixed 
Product Version4.3.5 
Summary16519: For specific screen navigation, condition is not saved properly
Description

For specific screen navigation, condition is not saved properly
That could lead to a situation where:

  • After updating an answer option,
  • The related condition doesn't get updated
  • The condition uses an answer option code which doesn't exists
Steps To Reproduce

1 - Create a survey with 2 questions

  • Q1: List. Options Y, N, Maybe
  • Q2: Short Free Text

2 - Add the following condition on Q2
Q1 = Y

3 - Update Q1. Set answer option code for Y to be different.

4 - Condition on Q2 hasn't been updated and it is using the wrong answer option code.

Additional Information

Detected while reviewing 15945

TagsNo tags attached.
Bug heat8
Complete LimeSurvey version number (& build)4.3.5
I will donate to the project if issue is resolvedNo
Browser
Database type & versionMysql
Server OS (if known)
Webserver software & version (if known)
PHP Versionphp

Relationships

Relationship GraphDependency Graph
related to 16520 closed For specific screen navigation, condition is not saved properly 
related to 16521 closed After updating an answer option, the related condition doesn't get updated 

Users monitoring this issue

There are no users monitoring this issue.

Activities

gabrieljenik

gabrieljenik

2020-07-28 18:56

manager   ~59126

PR: https://github.com/LimeSurvey/LimeSurvey/pull/1506

user225042

2020-07-30 10:35

  ~59193

Last edited: 2020-07-31 11:13

Tested the issue before pulling the PR, Issue exist. Tested the issue after pulling the PR, but still I don't see any updates or changes. I tried clearing cache but it is the same
Please refer the attachment for more details

16519_Beforepulling_PR.png (264,570 bytes)
16519_Afterpulling_PR.png (130,899 bytes)

user225042

2020-07-30 16:02

  ~59214

Last edited: 2020-07-31 11:13

The above issue was shown because I was committed to only one branch and checking. Checked the issue with Dorin with all the branches committed for Condition designer and working as expected.
gabrieljenik

gabrieljenik

2020-07-30 16:13

manager   ~59218

Last edited: 2020-07-31 11:13

Tested the issue before pulling the PR, Issue does not exist.
Were you able to finally reproduce the issue?

user231563

2020-07-31 10:03

  ~59229

Last edited: 2020-07-31 11:13

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=30331
lime_release_bot

lime_release_bot

2020-08-03 11:23

administrator   ~59253

Fixed in Release 4.3.8+200803

Related Changesets

LimeSurvey: master 492a855f

2020-07-28 20:55

gabrieljenik

Committer: user231563


Details Diff		 Fixed issue 16519: For specific screen navigation, condition is not saved properly

Resetting cqid when using token fields		 Affected Issues
16519
mod - application/controllers/admin/conditionsaction.php Diff File
mod - assets/scripts/admin/conditions.js Diff File

Issue History

Date Modified Username Field Change
2020-07-22 17:15 gabrieljenik New Issue
2020-07-22 17:15 gabrieljenik Issue cloned: 16520
2020-07-22 17:15 gabrieljenik Relationship added related to 16520
2020-07-22 17:24 user225042 Status new => confirmed
2020-07-22 17:24 user225042 Zoho Sprints => |Yes|
2020-07-22 17:24 swendrich Zoho Sprints ID => 14469000000188001
2020-07-22 18:22 gabrieljenik Issue cloned: 16521
2020-07-22 18:22 gabrieljenik Relationship added related to 16521
2020-07-28 18:56 gabrieljenik Note Added: 59126
2020-07-30 10:35 user225042 Note Added: 59193
2020-07-30 10:35 user225042 File Added: 16519_Beforepulling_PR.png
2020-07-30 10:35 user225042 File Added: 16519_Afterpulling_PR.png
2020-07-30 16:02 user225042 Note Added: 59214
2020-07-30 16:13 gabrieljenik Note Added: 59218
2020-07-31 10:03 user231563 Changeset attached => LimeSurvey master 492a855f
2020-07-31 10:03 user231563 Note Added: 59229
2020-07-31 11:13 swendrich Zoho Sprints Yes => |Yes|
2020-07-31 11:13 swendrich Status confirmed => resolved
2020-08-03 11:23 lime_release_bot Zoho Sprints Yes => |Yes|
2020-08-03 11:23 lime_release_bot Note Added: 59253
2020-08-03 11:23 lime_release_bot Status resolved => closed
2020-08-03 11:23 lime_release_bot Resolution open => fixed