View Issue Details

Related ChangesetsJump to NotesJump to History
This bug affects 1 person(s).
 6
IDProjectCategoryView StatusDate SubmittedLast Update
16870Bug reportsAssessmentspublic2020-12-01 15:482021-03-29 12:32
Reportergabrieljenik Assigned Togabrieljenik  
PrioritynoneSeveritypartial_block 
Status closedResolutionfixed 
Product Version3.22.26 
Summary16870: When saving, an empty rule is being added
Description

When hitting the save button (from the topbar) on the assessments page, an empy rule is being added.
Seems the button is not necessary.

Steps To Reproduce

When adding assessment rules to a survey, the rules are saved by clicking on the Save button of the modal dialog. However, there is also a Save button in the toolbar. Clicking on that Save button ends up creating a new empty rule.

TagsNo tags attached.
Bug heat6
Complete LimeSurvey version number (& build)3.22.26
I will donate to the project if issue is resolvedNo
Browser
Database type & versionMysql
Server OS (if known)
Webserver software & version (if known)
PHP Version7

Users monitoring this issue

There are no users monitoring this issue.

Activities

ollehar

ollehar

2021-03-10 17:17

administrator   ~63072

You're using an outdated version of LimeSurvey. Please update to the latest version and check if the bug can still be reproduced. Thank you.
gabrieljenik

gabrieljenik

2021-03-12 15:50

manager   ~63340

Last edited: 2021-03-25 17:02

You mean check it on LTS or LS4?
ollehar

ollehar

2021-03-12 15:55

administrator   ~63341

Last edited: 2021-03-25 17:02

LTS, since it's reported for 3.22.
gabrieljenik

gabrieljenik

2021-03-25 17:32

manager   ~63623

Removing save button as to be the same as in LS4. Issue will be avoided
PR: https://github.com/LimeSurvey/LimeSurvey/pull/1820
gabrieljenik

gabrieljenik

2021-03-25 20:18

manager   ~63632

Fix committed to 3.x-LTS branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=31394
lime_release_bot

lime_release_bot

2021-03-29 12:32

administrator   ~63694

Fixed in Release 3.25.20+210330

Related Changesets

LimeSurvey: 3.x-LTS edca6f0d

2021-03-25 21:18

gabrieljenik

Committer: GitHub


Details Diff		 Fixed issue 16870: When saving, an empty rule is being added (#1820) Affected Issues
16870
mod - application/controllers/admin/assessments.php Diff File

Issue History

Date Modified Username Field Change
2020-12-01 15:48 gabrieljenik New Issue
2020-12-01 15:49 gabrieljenik Issue cloned: 16871
2020-12-01 16:04 gabrieljenik Steps to Reproduce Updated
2020-12-01 16:13 gabrieljenik Product Version 3.25.2 => 3.22.26
2020-12-01 16:13 gabrieljenik Complete LimeSurvey version number (& build) 3.25.2 => 3.22.26
2021-03-10 17:17 ollehar Assigned To => ollehar
2021-03-10 17:17 ollehar Status new => feedback
2021-03-10 17:17 ollehar Note Added: 63072
2021-03-12 15:50 gabrieljenik Note Added: 63340
2021-03-12 15:50 gabrieljenik Status feedback => assigned
2021-03-12 15:55 ollehar Note Added: 63341
2021-03-25 16:57 c_schmitz Sync to Zoho Project => |Yes|
2021-03-25 17:32 gabrieljenik Note Added: 63623
2021-03-25 20:18 gabrieljenik Changeset attached => LimeSurvey 3.x-LTS edca6f0d
2021-03-25 20:18 gabrieljenik Note Added: 63632
2021-03-25 20:18 gabrieljenik Assigned To ollehar => gabrieljenik
2021-03-25 20:18 gabrieljenik Resolution open => fixed
2021-03-25 20:20 c_schmitz Status assigned => resolved
2021-03-29 12:32 lime_release_bot Sync to Zoho Project Yes => |Yes|
2021-03-29 12:32 lime_release_bot Note Added: 63694
2021-03-29 12:32 lime_release_bot Status resolved => closed