View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
17075 | Bug reports | User / Groups / Roles | public | 2021-02-10 14:23 | 2021-02-15 22:40 |
Reporter | DenisChenu | Assigned To | DenisChenu | ||
Priority | none | Severity | partial_block | ||
Status | closed | Resolution | fixed | ||
Product Version | 4.4.4 | ||||
Fixed in Version | 4.4.4 | ||||
Summary | 17075: User roles : all rights are enabled | ||||
Description | When edit user roles, no way to remove permission | ||||
Steps To Reproduce | See screencast | ||||
Additional Information | |||||
Tags | No tags attached. | ||||
Attached Files | |||||
Bug heat | 6 | ||||
Complete LimeSurvey version number (& build) | 4.4.4 | ||||
I will donate to the project if issue is resolved | No | ||||
Browser | not relevant | ||||
Database type & version | not relevant? | ||||
Server OS (if known) | not relevant ? | ||||
Webserver software & version (if known) | not relevant ? | ||||
PHP Version | not relevant ? | ||||
Denis, do you have access to severity level? Is this really minor? |
|
major ? I don't like block … |
|
One could argue it's blocking the workflow to assign permissions...? Or? |
|
@ollehar : do you have any idea why this issue didn't happen before ? See forum post :
by user |
|
Public survey : no issue ;) partial_block if you use roles only :) |
|
https://github.com/LimeSurvey/LimeSurvey/pull/1755 I'm sure at 100% of my fix but
|
|
Renaming functions are fine. As long as it makes sense. :) |
|
I consider "block" to be "blocking for a workflow [for many users]" - can be admin interface or anything. Partial block = blocking workflow for some users. |
|
Here :
But all action can be done ;) It's not block (but it's a major potential leak of data ;) ) |
|
Not the workflow of controlling permissions... Anyway. |
|
:D major potential leak of data But on a new feature ;) role didn't exist in 3.X |
|
New severity level for security issues needed? |
|
Maybe :) |
|
But i like to have for start |
|
Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=31053 |
|
Fixed in Release 4.4.7+210215 |
|
LimeSurvey: master 6dbe2cb4 2021-02-10 16:11 Details Diff |
Fixed issue 17075: User roles : all rights are enabled Dev: clarify functionname in Permission Dev: use directly DB checking |
Affected Issues 17075 |
|
mod - application/models/Permission.php | Diff File | ||
mod - application/models/Permissiontemplates.php | Diff File | ||
mod - application/views/admin/permissiontemplates/partials/_permissions.php | Diff File | ||
LimeSurvey: master 08aba601 2021-02-11 15:56 Committer: GitHub Details Diff |
Fixed issue 17075: User roles : all rights are enabled Merge pull request #1755 from Shnoulle/master_17075 |
Affected Issues 17075 |
|
mod - application/models/Permission.php | Diff File | ||
mod - application/models/Permissiontemplates.php | Diff File | ||
mod - application/views/admin/permissiontemplates/partials/_permissions.php | Diff File |
Date Modified | Username | Field | Change |
---|---|---|---|
2021-02-10 14:23 | DenisChenu | New Issue | |
2021-02-10 14:23 | DenisChenu | File Added: Peek 10-02-2021 14-21.gif | |
2021-02-10 14:33 | ollehar | Note Added: 62103 | |
2021-02-10 14:33 | ollehar | Note Edited: 62103 | |
2021-02-10 14:38 | DenisChenu | Severity | minor => partial_block |
2021-02-10 14:38 | DenisChenu | Note Added: 62104 | |
2021-02-10 14:38 | DenisChenu | Assigned To | => DenisChenu |
2021-02-10 14:38 | DenisChenu | Status | new => assigned |
2021-02-10 14:40 | ollehar | Note Added: 62105 | |
2021-02-10 14:46 | DenisChenu | Note Added: 62106 | |
2021-02-10 14:46 | DenisChenu | Note Added: 62107 | |
2021-02-10 15:16 | DenisChenu | Assigned To | DenisChenu => ollehar |
2021-02-10 15:16 | DenisChenu | Status | assigned => ready for testing |
2021-02-10 15:16 | DenisChenu | Note Added: 62109 | |
2021-02-10 16:45 | ollehar | Note Added: 62118 | |
2021-02-10 16:46 | ollehar | Note Added: 62119 | |
2021-02-10 17:05 | DenisChenu | Note Added: 62122 | |
2021-02-10 17:05 | DenisChenu | Note Edited: 62122 | |
2021-02-10 17:08 | ollehar | Note Added: 62123 | |
2021-02-10 17:08 | ollehar | Note Edited: 62123 | |
2021-02-10 17:10 | DenisChenu | Note Added: 62124 | |
2021-02-10 17:13 | ollehar | Note Added: 62125 | |
2021-02-10 17:14 | DenisChenu | Note Added: 62126 | |
2021-02-10 17:14 | DenisChenu | Note Added: 62127 | |
2021-02-11 14:56 | ollehar | Changeset attached | => LimeSurvey master 08aba601 |
2021-02-11 14:56 | DenisChenu | Changeset attached | => LimeSurvey master 6dbe2cb4 |
2021-02-11 14:56 | DenisChenu | Note Added: 62164 | |
2021-02-11 14:56 | DenisChenu | Assigned To | ollehar => DenisChenu |
2021-02-11 14:56 | DenisChenu | Resolution | open => fixed |
2021-02-11 15:50 | DenisChenu | Status | ready for testing => resolved |
2021-02-11 15:50 | DenisChenu | Fixed in Version | => 4.4.4 |
2021-02-15 22:40 | lime_release_bot | Note Added: 62271 | |
2021-02-15 22:40 | lime_release_bot | Status | resolved => closed |