View Issue Details

Related ChangesetsJump to NotesJump to History
This bug affects 1 person(s).
 22
IDProjectCategoryView StatusDate SubmittedLast Update
18373Bug reportsStatisticspublic2022-09-26 10:282022-12-15 13:54
Reporterdavebostockgmail Assigned Togabrieljenik  
PriorityhighSeverityblock 
Status closedResolutionfixed 
Product Version5.4.x 
Summary18373: Saving statistics exports to excel fails
Description

Exporting statistics to excel fails with the message

statistics.js:608 Uncaught ReferenceError: saveAs is not defined
at xhr.onload (statistics.js:608:17)

on further inspection the code that fails contains 

            // saveAs is implemented by jszip/fileSaver.js
            saveAs(xhr.response, fileName);

and looking deeper into this it appears that it needs this module to work correctly : https://github.com/eligrey/FileSaver.js

Steps To Reproduce

Steps to reproduce

Try to export statistics to Excel

Expected result

Excel file produced

Actual result

The Gif just spins with no output

TagsNo tags attached.
Bug heat22
Complete LimeSurvey version number (& build)Version 5.4.2+220921
I will donate to the project if issue is resolvedNo
BrowserChrome
Database type & versionMySQL
Server OS (if known)Ubuntu
Webserver software & version (if known)Apache 2.0
PHP Version7.8

Relationships

Relationship GraphDependency Graph
has duplicate 18322 closedollehar Export statistics in PDF - No PDF created 

Users monitoring this issue

jpilette, ollehar

Activities

gabrieljenik

gabrieljenik

2022-09-26 18:04

manager   ~71950

Last edited: 2022-09-26 18:04

@davebostockgmail Seems you have a technical background.
Want to give it a try and test the PR?
gabrieljenik

gabrieljenik

2022-09-26 18:04

manager   ~71951

PR: https://github.com/LimeSurvey/LimeSurvey/pull/2634
DenisChenu

DenisChenu

2022-09-26 18:49

developer   ~71957

@davebostockgmail : if yoiu can test tyhe PR , please!
:)
davebostockgmail

davebostockgmail

2022-09-27 07:46

reporter   ~71963

Thanks .. this seems to have fixed the issue and I am now able to export to Excel from the statistics page.
gabrieljenik

gabrieljenik

2022-10-04 12:22

manager   ~72069

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=33929
davebostockgmail

davebostockgmail

2022-10-05 11:38

reporter   ~72103

I have just looked at the comfort update option after making the fix for this (which worked) and I now get the following error (see attached screenshot)

How do I go back to a version that allows me to use the fix and still use comfort update?

Thanks
Dave

Capture.PNG (14,896 bytes)   
Capture.PNG (14,896 bytes)   
gabrieljenik

gabrieljenik

2022-10-05 14:23

manager   ~72105

Last edited: 2022-10-05 14:24

I believe these issues are unrelated...
Please, can I asl you to open a new ticket?
It will allow better management and handling from our side...
davebostockgmail

davebostockgmail

2022-10-06 08:34

reporter   ~72135

OK so I have manged to fix it by using my old version.php that was changed during the update to the fix. This allowed me to run comfortupdate as expected.

However the version in the latest comfort update (which updates to Version 5.4.4+221004) does not include this fix to the Stats Export ... I have updated the third_party.php file manually and it is working again for me.

Thanks
Dave
LimeBot

LimeBot

2022-10-10 10:47

administrator   ~72176

Fixed in Release 5.4.5+221010
gabrieljenik

gabrieljenik

2022-10-11 22:09

manager   ~72204

PR for develop: https://github.com/LimeSurvey/LimeSurvey/pull/2656
gabrieljenik

gabrieljenik

2022-12-15 13:54

manager   ~73126

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=34136

Related Changesets

LimeSurvey: master cbffb148

2022-10-04 14:20

gabrieljenik

Committer: GitHub


Details Diff		 Fixed issue 18373: Saving statistics exports to excel fails (#2634)

- Needed packages were not loaded by pjax

Co-authored-by: encuestabizdevgit <devgit@encuesta.biz>		 Affected Issues
18373
mod - application/config/third_party.php Diff File

LimeSurvey: master 29fd5b08

2022-11-24 15:32

gabrieljenik

Committer: GitHub


Details Diff		 Fixed issue 18373: Saving statistics exports to excel fails (#2656)

Co-authored-by: encuestabizdevgit <devgit@encuesta.biz>		 Affected Issues
18373
mod - application/config/vendor.php Diff File

Issue History

Date Modified Username Field Change
2022-09-26 10:28 davebostockgmail New Issue
2022-09-26 13:10 ollehar Priority none => high
2022-09-26 15:12 gabrieljenik Assigned To => gabrieljenik
2022-09-26 15:12 gabrieljenik Status new => assigned
2022-09-26 18:03 gabrieljenik Assigned To gabrieljenik => DenisChenu
2022-09-26 18:03 gabrieljenik Status assigned => ready for code review
2022-09-26 18:04 gabrieljenik Note Added: 71950
2022-09-26 18:04 gabrieljenik Bug heat 0 => 2
2022-09-26 18:04 gabrieljenik Note Added: 71951
2022-09-26 18:04 gabrieljenik Note Edited: 71950
2022-09-26 18:49 DenisChenu Note Added: 71957
2022-09-26 18:49 DenisChenu Bug heat 2 => 4
2022-09-26 18:49 DenisChenu Assigned To DenisChenu =>
2022-09-26 18:49 DenisChenu Status ready for code review => ready for testing
2022-09-26 20:34 gabrieljenik Relationship added related to 18322
2022-09-27 07:46 davebostockgmail Note Added: 71963
2022-09-27 07:46 davebostockgmail Bug heat 4 => 6
2022-09-27 14:44 gabrieljenik Assigned To => ollehar
2022-09-27 14:44 gabrieljenik Status ready for testing => ready for merge
2022-09-27 15:09 gabrieljenik Relationship replaced has duplicate 18322
2022-09-27 15:09 gabrieljenik Bug heat 6 => 16
2022-09-27 15:09 gabrieljenik Issue Monitored: jpilette
2022-09-27 15:09 gabrieljenik Bug heat 16 => 18
2022-09-27 15:09 gabrieljenik Issue Monitored: ollehar
2022-09-27 15:09 gabrieljenik Bug heat 18 => 20
2022-10-04 12:22 gabrieljenik Changeset attached => LimeSurvey master cbffb148
2022-10-04 12:22 gabrieljenik Note Added: 72069
2022-10-04 12:22 gabrieljenik Assigned To ollehar => gabrieljenik
2022-10-04 12:22 gabrieljenik Resolution open => fixed
2022-10-05 11:38 davebostockgmail Note Added: 72103
2022-10-05 11:38 davebostockgmail File Added: Capture.PNG
2022-10-05 14:23 gabrieljenik Note Added: 72105
2022-10-05 14:24 gabrieljenik Note Edited: 72105
2022-10-06 08:34 davebostockgmail Note Added: 72135
2022-10-10 10:47 LimeBot Note Added: 72176
2022-10-10 10:47 LimeBot Status ready for merge => closed
2022-10-10 10:47 LimeBot Bug heat 20 => 22
2022-10-11 22:09 gabrieljenik Note Added: 72204
2022-12-15 13:54 gabrieljenik Changeset attached => LimeSurvey master 29fd5b08
2022-12-15 13:54 gabrieljenik Note Added: 73126