View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
18786 | Bug reports | Survey participants (Tokens) | public | 2023-04-25 12:01 | 2023-05-02 10:20 |
Reporter | Mazi | Assigned To | c_schmitz | ||
Priority | none | Severity | block | ||
Status | closed | Resolution | fixed | ||
Product Version | 5.6.x | ||||
Summary | 18786: Wrong token length check, update from 2.x to 5.x causes problems | ||||
Description | We have updated an old 2.0x system to the latest 5.x version. At the old system the token length was set to 36. The token length shows the old value from v2.0x which is 36. The token column at the DB is defined as VARCHAR(36) after the update. We can also create new tokens and dummy tokens with the token length of 36. But we can not save the participant setting. From my point of view the limit has to be 36 and not 35. | ||||
Steps To Reproduce | Steps to reproduceTry to set a token length of 36. Expected resultAccepts 36 as maximum value. Actual resultError message "Survey could not be updated, please fix the following error: | ||||
Tags | No tags attached. | ||||
Attached Files | |||||
Bug heat | 6 | ||||
Complete LimeSurvey version number (& build) | 5.6.x | ||||
I will donate to the project if issue is resolved | No | ||||
Browser | Chrome | ||||
Database type & version | MySQL | ||||
Server OS (if known) | Ubuntu 20 | ||||
Webserver software & version (if known) | Apache | ||||
PHP Version | PHP 7.4 | ||||
@DenisChenu, do you agree that the field validation is wrong and token length allowed maximum should be 36?! |
|
Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=34524 |
|
Fix committed to 5.x branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=34525 |
|
I am not sure if this could become a issue in the future again, IF there maybe were token tables created which had only a field length of 35 characters. We will see, I guess. |
|
@c_schmitz, thanks a lot for the very quick fix. Just for your information: At the migrated DB with >200 surveys some had a token length defined of 60. That passed the DB migration which is one potential error. It also leads to errors when generating new tokens. Error I get is: We fixed this by a DB update and setting these to a max length of 36. |
|
Fixed in Release 6.0.5+230502 |
|
LimeSurvey: master 24cfac42 2023-04-25 16:31 Details Diff |
Fixed issue 18786: Error shown when token length is set to 36 characters |
Affected Issues 18786 |
|
mod - application/controllers/admin/Database.php | Diff File | ||
mod - application/helpers/admin/import_helper.php | Diff File | ||
mod - application/models/Survey.php | Diff File | ||
LimeSurvey: 5.x 19bf0d52 2023-04-25 16:31 Details Diff |
Fixed issue 18786: Error shown when token length is set to 36 characters |
Affected Issues 18786 |
|
mod - application/controllers/admin/Database.php | Diff File | ||
mod - application/helpers/admin/import_helper.php | Diff File | ||
mod - application/models/Survey.php | Diff File |
Date Modified | Username | Field | Change |
---|---|---|---|
2023-04-25 12:01 | Mazi | New Issue | |
2023-04-25 12:01 | Mazi | File Added: image.png | |
2023-04-25 13:53 | Mazi | Note Added: 74626 | |
2023-04-25 13:53 | Mazi | Bug heat | 0 => 2 |
2023-04-25 14:31 | DenisChenu | Assigned To | => DenisChenu |
2023-04-25 14:31 | DenisChenu | Status | new => assigned |
2023-04-25 14:32 | c_schmitz | Changeset attached | => LimeSurvey master 24cfac42 |
2023-04-25 14:32 | c_schmitz | Note Added: 74627 | |
2023-04-25 14:32 | c_schmitz | Bug heat | 2 => 4 |
2023-04-25 14:32 | c_schmitz | Assigned To | DenisChenu => c_schmitz |
2023-04-25 14:32 | c_schmitz | Resolution | open => fixed |
2023-04-25 14:49 | c_schmitz | Changeset attached | => LimeSurvey 5.x 19bf0d52 |
2023-04-25 14:49 | c_schmitz | Note Added: 74629 | |
2023-04-25 14:53 | c_schmitz | Status | assigned => resolved |
2023-04-25 14:54 | c_schmitz | Note Added: 74634 | |
2023-04-25 15:28 | Mazi | Note Added: 74637 | |
2023-05-02 10:20 | LimeBot | Note Added: 74737 | |
2023-05-02 10:20 | LimeBot | Status | resolved => closed |
2023-05-02 10:20 | LimeBot | Bug heat | 4 => 6 |