View Issue Details

Related ChangesetsJump to NotesJump to History
This bug affects 1 person(s).
 8
IDProjectCategoryView StatusDate SubmittedLast Update
19057Bug reportsSurvey participants (Tokens)public2023-08-29 09:482023-10-30 10:54
Reporterritapas Assigned Tomfavetti  
PrioritynoneSeveritytrivial 
Status closedResolutionfixed 
Product Version5.6.x 
Summary19057: incorrect handling of wrong input in create dummy participant form
Description

if you create 0 dummy participants and press save and close, form is closed, no dummy participant created but popup window says "New dummy participants were added."

Steps To Reproduce

Steps to reproduce

create a dummy participant set but put 0 in the field Number of participants: , press save and close

Expected result

field Number of participants: should be validated against <1

Actual result

no participant created (correct) but popup window says "New dummy participants were added."

TagsNo tags attached.
Bug heat8
Complete LimeSurvey version number (& build) 5.6.33 (build 230808)
I will donate to the project if issue is resolvedNo
Browser
Database type & versionn/a
Server OS (if known)
Webserver software & version (if known)
PHP Versionn/a

Users monitoring this issue

There are no users monitoring this issue.

Activities

mfavetti

mfavetti

2023-10-24 09:39

developer   ~77900

so many issues here, i have to limit to fixing this particular issue or be stuck forever:

frontend: don't allow zero
backend: add case for zero amount to display different flash message

also affects master
mfavetti

mfavetti

2023-10-24 09:48

developer   ~77901

master: https://github.com/LimeSurvey/LimeSurvey/pull/3567
5.x: https://github.com/LimeSurvey/LimeSurvey/pull/3568
DenisChenu

DenisChenu

2023-10-24 15:57

developer   ~77917

Code is OK,
Can be improved but not needed
mfavetti

mfavetti

2023-10-25 00:14

developer   ~77947

To reproduce:

LimeSurvey - Google Chrome 2023-10-24 15-04-55_720p.mp4 (2,320,602 bytes)   
LimeSurvey - Google Chrome 2023-10-24 15-04-55_720p.mp4 (2,320,602 bytes)   
mfavetti

mfavetti

2023-10-25 00:42

developer   ~77953

after fix:

LimeSurvey - Google Chrome 2023-10-24 15-39-59-converted.mp4 (1,560,387 bytes)   
LimeSurvey - Google Chrome 2023-10-24 15-39-59-converted.mp4 (1,560,387 bytes)   
tibor.pacalat

tibor.pacalat

2023-10-26 17:30

administrator   ~78056

@mfavetti for master I found following issue:
If I first try to create zero dummy participants, I get validation feedback -> great!
But, when I try correct it, the button "Save and close" is disabled.
mfavetti

mfavetti

2023-10-26 17:39

developer   ~78057

Fix committed to 5.x branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=35684
mfavetti

mfavetti

2023-10-26 21:58

developer   ~78067

@tibor.pacalat

thanks, I will check out the issue you see on master pr
mfavetti

mfavetti

2023-10-27 09:29

developer   ~78072

@tibor.pacalat

I cannot reproduce the behavior you described on fresh install with php 8.0/8.1/8.2 and debug 0/1/2 on my branch

any other info that might help?
mfavetti

mfavetti

2023-10-27 09:32

developer   ~78073

here's what I see on my branch:

LimeSurvey - Google Chrome 2023-10-27 00-31-24-converted.mp4 (1,097,036 bytes)   
LimeSurvey - Google Chrome 2023-10-27 00-31-24-converted.mp4 (1,097,036 bytes)   
mfavetti

mfavetti

2023-10-27 13:40

developer   ~78088

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=35687
tibor.pacalat

tibor.pacalat

2023-10-27 13:40

administrator   ~78089

@mfavetti I retested it and now it works as expected, sorry for false alarm ;)
tibor.pacalat

tibor.pacalat

2023-10-27 13:41

administrator   ~78090

Tested and merged.
LimeBot

LimeBot

2023-10-30 10:54

administrator   ~78130

Fixed in Release 5.6.43+231030

Related Changesets

LimeSurvey: 5.x 0620055c

2023-10-26 19:28

mfavetti

Committer: GitHub


Details Diff		 Fixed issue 19057: incorrect handling of wrong input in create dummy participant form (03568) Affected Issues
19057
mod - application/controllers/admin/Tokens.php Diff File
mod - application/views/admin/token/dummytokenform.php Diff File

LimeSurvey: master 28e201fe

2023-10-27 15:40

mfavetti

Committer: GitHub


Details Diff		 Fixed issue 19057: incorrect handling of wrong input in create dummy participant form (03567) Affected Issues
19057
mod - application/controllers/admin/Tokens.php Diff File
mod - application/views/admin/token/dummytokenform.php Diff File

Issue History

Date Modified Username Field Change
2023-08-29 09:48 ritapas New Issue
2023-08-29 21:09 gabrieljenik Assigned To => gabrieljenik
2023-08-29 21:09 gabrieljenik Status new => assigned
2023-09-08 21:01 gabrieljenik Assigned To gabrieljenik =>
2023-10-23 20:51 gabrieljenik Status assigned => confirmed
2023-10-24 01:57 mfavetti Assigned To => mfavetti
2023-10-24 01:57 mfavetti Status confirmed => assigned
2023-10-24 09:39 mfavetti Note Added: 77900
2023-10-24 09:39 mfavetti Bug heat 0 => 2
2023-10-24 09:48 mfavetti Note Added: 77901
2023-10-24 09:48 mfavetti Assigned To mfavetti => DenisChenu
2023-10-24 09:48 mfavetti Status assigned => ready for code review
2023-10-24 10:38 DenisChenu Status ready for code review => in code review
2023-10-24 15:56 DenisChenu Assigned To DenisChenu => mfavetti
2023-10-24 15:57 DenisChenu Note Added: 77917
2023-10-24 15:57 DenisChenu Bug heat 2 => 4
2023-10-25 00:14 mfavetti Note Added: 77947
2023-10-25 00:14 mfavetti File Added: LimeSurvey - Google Chrome 2023-10-24 15-04-55_720p.mp4
2023-10-25 00:42 mfavetti Note Added: 77953
2023-10-25 00:42 mfavetti File Added: LimeSurvey - Google Chrome 2023-10-24 15-39-59-converted.mp4
2023-10-25 17:45 tibor.pacalat Assigned To mfavetti => tibor.pacalat
2023-10-25 17:45 tibor.pacalat Status in code review => ready for testing
2023-10-26 17:30 tibor.pacalat Note Added: 78056
2023-10-26 17:30 tibor.pacalat Bug heat 4 => 6
2023-10-26 17:39 mfavetti Changeset attached => LimeSurvey 5.x 0620055c
2023-10-26 17:39 mfavetti Note Added: 78057
2023-10-26 17:39 mfavetti Assigned To tibor.pacalat => mfavetti
2023-10-26 17:39 mfavetti Resolution open => fixed
2023-10-26 21:58 mfavetti Note Added: 78067
2023-10-27 09:29 mfavetti Note Added: 78072
2023-10-27 09:32 mfavetti Note Added: 78073
2023-10-27 09:32 mfavetti File Added: LimeSurvey - Google Chrome 2023-10-27 00-31-24-converted.mp4
2023-10-27 13:40 mfavetti Changeset attached => LimeSurvey master 28e201fe
2023-10-27 13:40 mfavetti Note Added: 78088
2023-10-27 13:40 tibor.pacalat Note Added: 78089
2023-10-27 13:41 tibor.pacalat Status ready for testing => resolved
2023-10-27 13:41 tibor.pacalat Note Added: 78090
2023-10-30 10:54 LimeBot Note Added: 78130
2023-10-30 10:54 LimeBot Status resolved => closed
2023-10-30 10:54 LimeBot Bug heat 6 => 8