View Issue Details

Related ChangesetsJump to NotesJump to History
This bug affects 1 person(s).
 10
IDProjectCategoryView StatusDate SubmittedLast Update
19180Bug reportsUsability/user experiencepublic2023-10-19 09:392023-10-23 09:31
Reportermfavetti Assigned Tomfavetti  
PrioritynoneSeverityblock 
Status closedResolutionfixed 
Product Version6.2.x 
Summary19180: SMTP settings are not enabled when SMTP is selected in global settings
Description

Originally reported by wooddk on discord#general

When you select SMTP in the global settings, the relevant settings stay disabled.

Steps To Reproduce

Steps to reproduce

Configuration -> Global -> Email settings
Select SMTP for Email method

Expected result

SMTP host, username, and password inputs are enabled

Actual result

SMTP host, username, and password inputs stay disabled

TagsNo tags attached.
Bug heat10
Complete LimeSurvey version number (& build)d3fb278e57e5561a62b1e05c619db5b1c5fbef73
I will donate to the project if issue is resolvedNo
Browser
Database type & versionn/a
Server OS (if known)
Webserver software & version (if known)
PHP Versionn/a

Users monitoring this issue

mfavetti

Activities

mfavetti

mfavetti

2023-10-19 09:42

developer   ~77774

Caused by poor edit to global settings js in pr #3054

https://github.com/LimeSurvey/LimeSurvey/pull/3551
ollehar

ollehar

2023-10-19 10:08

administrator   ~77775

Is this the only global setting that's not saved?
mfavetti

mfavetti

2023-10-19 10:13

developer   ~77776

Last edited: 2023-10-19 10:15

if you select smtp, there is no way to set the relevant settings because they are always disabled

its not about the setting not being saved
you cannot enter anything to change the setting in the first place
mfavetti

mfavetti

2023-10-19 10:16

developer   ~77777

Last edited: 2023-10-19 10:28

whoever changed this js file added functionality to support a new plugin method, but changed the existing smtp functionality in a way that makes no sense. they replaced a variable (that depended on if smtp was selected) with a constant of true... ¯\(ツ)/¯
DenisChenu

DenisChenu

2023-10-19 11:27

developer   ~77780

Looking at code : seems there are an issue.
mfavetti

mfavetti

2023-10-19 19:48

developer   ~77795

i replied in the pr
DenisChenu

DenisChenu

2023-10-20 08:23

developer   ~77797

Ready for testing
mfavetti

mfavetti

2023-10-20 10:16

developer   ~77801

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=35642
LimeBot

LimeBot

2023-10-23 09:31

administrator   ~77841

Fixed in Release 6.3.1+231023

Related Changesets

LimeSurvey: master d24258e6

2023-10-20 12:16

mfavetti

Committer: GitHub


Details Diff		 Fixed issue 19180: SMTP settings are not enabled when SMTP is selected in global settings (03551) Affected Issues
19180
mod - assets/scripts/admin/globalsettings.js Diff File

Issue History

Date Modified Username Field Change
2023-10-19 09:39 mfavetti New Issue
2023-10-19 09:42 mfavetti Note Added: 77774
2023-10-19 09:42 mfavetti Bug heat 0 => 2
2023-10-19 09:42 mfavetti Assigned To => mfavetti
2023-10-19 09:42 mfavetti Status new => assigned
2023-10-19 10:08 ollehar Note Added: 77775
2023-10-19 10:08 ollehar Bug heat 2 => 4
2023-10-19 10:13 mfavetti Note Added: 77776
2023-10-19 10:14 mfavetti Note Edited: 77776
2023-10-19 10:14 mfavetti Note Edited: 77776
2023-10-19 10:15 mfavetti Note Edited: 77776
2023-10-19 10:16 mfavetti Note Added: 77777
2023-10-19 10:17 mfavetti Note Edited: 77777
2023-10-19 10:17 mfavetti Note Edited: 77777
2023-10-19 10:17 mfavetti Note Edited: 77777
2023-10-19 10:20 mfavetti Steps to Reproduce Updated
2023-10-19 10:28 mfavetti Note Edited: 77777
2023-10-19 11:24 DenisChenu Assigned To mfavetti => DenisChenu
2023-10-19 11:24 DenisChenu Status assigned => ready for code review
2023-10-19 11:27 DenisChenu Assigned To DenisChenu => mfavetti
2023-10-19 11:27 DenisChenu Status ready for code review => in code review
2023-10-19 11:27 DenisChenu Note Added: 77780
2023-10-19 11:27 DenisChenu Bug heat 4 => 6
2023-10-19 19:48 mfavetti Note Added: 77795
2023-10-20 08:23 DenisChenu Assigned To mfavetti => tibor.pacalat
2023-10-20 08:23 DenisChenu Status in code review => ready for testing
2023-10-20 08:23 DenisChenu Note Added: 77797
2023-10-20 10:16 mfavetti Changeset attached => LimeSurvey master d24258e6
2023-10-20 10:16 mfavetti Note Added: 77801
2023-10-20 10:16 mfavetti Assigned To tibor.pacalat => mfavetti
2023-10-20 10:16 mfavetti Resolution open => fixed
2023-10-20 10:16 c_schmitz Status ready for testing => resolved
2023-10-20 21:58 mfavetti Issue Monitored: mfavetti
2023-10-20 21:58 mfavetti Bug heat 6 => 8
2023-10-23 09:31 LimeBot Note Added: 77841
2023-10-23 09:31 LimeBot Status resolved => closed
2023-10-23 09:31 LimeBot Bug heat 8 => 10