View Issue Details

This bug affects 2 person(s).
 14
IDProjectCategoryView StatusLast Update
19632Bug reportsOtherpublic2024-11-19 18:14
Reportertibor.pacalat Assigned Togabrieljenik  
PrioritynoneSeverityminor 
Status closedResolutionfixed 
Product Version6.5.x 
Summary19632: Make Limesurvey compatible with php8.3
Description

We need to make Limesurvey compatible with php8.3

https://www.atatus.com/blog/tools-to-check-php8-compatibility/#php-compatibility-checker

Subtasks:

  1. Update github workflow to use 8.3
  2. Run compatibility checker and document what needs to be addressed
  3. Make necessary changes

Let me know if you require more tickets for this task.

Steps To Reproduce

Steps to reproduce

(Replace this text with detailed step-by-step instructions on how to reproduce the issue)

Expected result

(Write here what you expected to happen)

Actual result

(Write here what happened instead)

TagsNo tags attached.
Bug heat14
Complete LimeSurvey version number (& build)6.5.14+240624
I will donate to the project if issue is resolvedNo
Browser
Database type & version.
Server OS (if known)
Webserver software & version (if known)
PHP Version.

Relationships

related to 19487 new Creation of dynamic property ExpressionManager::$substitutionVars is deprecated 
related to 19550 closedtibor.pacalat Calling get_class() without arguments is deprecated in php8.3 
related to 18802 closedtibor.pacalat Add support for PHP 8.2 
parent of 19685 closedgabrieljenik php8.3 compatibility - LS Core 
parent of 19686 closedtibor.pacalat php8.3 compatibility - robthree/twofactorauth 
parent of 19687 closedtibor.pacalat php8.3 compatibility - Zend (xmlrpc related) 
parent of 19688 closedtibor.pacalat php8.3 compatibility - pclzip 
parent of 19690 closedtibor.pacalat php8.3 compatibility - phpseclib 
parent of 19691 closedgabrieljenik php8.3 compatibility - pchart 
parent of 19692 closedgabrieljenik php8.3 compatibility - Pear 
related to 19689 closedtibor.pacalat php8.3 compatibility - Yii 

Users monitoring this issue

There are no users monitoring this issue.

Activities

DenisChenu

DenisChenu

2024-06-26 17:13

developer   ~80473

8.3 ;)

DenisChenu

DenisChenu

2024-06-26 17:18

developer   ~80476

Tonis already set 8.3 : https://github.com/LimeSurvey/LimeSurvey/pull/3839/files

gabrieljenik

gabrieljenik

2024-08-05 16:29

manager   ~80739

We have run the checker.

These are the impacted files.
Details inside the attached file.

LS Core

FILE: /var/www/html/limesurvey/application/helpers/expressions/em_manager_helper.php
FILE: /var/www/html/limesurvey/application/models/SurveyActivator.php
FILE: /var/www/html/limesurvey/vendor/kcfinder/core/class/uploader.php

Vendor / Libs

robthree/twofactorauth

FILE: /var/www/html/limesurvey/application/core/plugins/TwoFactorAdminLogin/vendor/robthree/twofactorauth/lib/TwoFactorAuth.php
FILE: /var/www/html/limesurvey/application/core/plugins/TwoFactorAdminLogin/vendor/robthree/twofactorauth/lib/Providers/Rng/
FILE: /var/www/html/limesurvey/application/core/plugins/TwoFactorAdminLogin/vendor/robthree/twofactorauth/tests/TwoFactorAuthTest.php

Zend

FILE: /var/www/html/limesurvey/application/helpers/Zend/XmlRpc/Server.php
FILE: /var/www/html/limesurvey/application/helpers/Zend/Validate/File/Count.php
FILE: /var/www/html/limesurvey/application/helpers/Zend/Validate/File/ImageSize.php
FILE: /var/www/html/limesurvey/application/helpers/Zend/Validate/File/Size.php
FILE: /var/www/html/limesurvey/application/helpers/Zend/Validate/File/FilesSize.php
FILE: /var/www/html/limesurvey/application/helpers/Zend/Validate/EmailAddress.php
FILE: /var/www/html/limesurvey/application/helpers/Zend/Validate/CreditCard.php
FILE: /var/www/html/limesurvey/application/helpers/Zend/Validate/StringLength.php
FILE: /var/www/html/limesurvey/application/helpers/Zend/Validate/Ip.php
FILE: /var/www/html/limesurvey/application/helpers/Zend/Validate/Hostname.php
FILE: /var/www/html/limesurvey/application/helpers/Zend/Validate/Date.php
FILE: /var/www/html/limesurvey/application/helpers/Zend/Validate/Db/Abstract.php
FILE: /var/www/html/limesurvey/application/helpers/Zend/Validate/InArray.php
FILE: /var/www/html/limesurvey/application/helpers/Zend/Validate/NotEmpty.php
FILE: /var/www/html/limesurvey/application/helpers/Zend/Validate/Between.php

pclzip

FILE: /var/www/html/limesurvey/vendor/pclzip/pclzip.lib.php

Yii

FILE: /var/www/html/limesurvey/vendor/yiisoft/yii/framework/base/CSecurityManager.php
FILE: /var/www/html/limesurvey/vendor/yiisoft/yii/framework/web/services/CWebService.php

phpseclib

FILE: /var/www/html/limesurvey/vendor/phpseclib/phpseclib/phpseclib/Crypt/Common/SymmetricKey.php

pchart

FILE: /var/www/html/limesurvey/vendor/pchart/pChart.class.php
FILE: /var/www/html/limesurvey/vendor/pchart/pData.class.php

Pear

FILE: /var/www/html/limesurvey/vendor/pear/pear-core-minimal/src/PEAR.php

TCPDF

FILE: /var/www/html/limesurvey/vendor/tecnickcom/tcpdf/include/tcpdf_static.php
FILE: /var/www/html/limesurvey/vendor/tecnickcom/tcpdf/tcpdf.php

19632.log.txt (94,550 bytes)   
gabrieljenik

gabrieljenik

2024-08-05 16:29

manager   ~80740

Let me know about next steps...

tibor.pacalat

tibor.pacalat

2024-08-06 09:32

administrator   ~80743

@gabrieljenik do you want to tackle these changes in separate tickets? Like one for Pear, one for TCPDF etc.

gabrieljenik

gabrieljenik

2024-08-06 14:54

manager   ~80750

Yes, I think it would be the best. Also, not sure if these updates should be done on DEV

tibor.pacalat

tibor.pacalat

2024-08-06 15:21

administrator   ~80751

Yeah I would say on dev first. I will create sub tickets.

tibor.pacalat

tibor.pacalat

2024-08-08 14:19

administrator   ~80762

Last edited: 2024-10-15 09:58

Ok, created tickets, please @gabrieljenik and @DenisChenu assign yourselves to these tickets.

https://bugs.limesurvey.org/view.php?id=19685 (resolved)
https://bugs.limesurvey.org/view.php?id=19686 (closed)
https://bugs.limesurvey.org/view.php?id=19687 (resolved)
https://bugs.limesurvey.org/view.php?id=19688 (closed)
https://bugs.limesurvey.org/view.php?id=19689 (closed)
https://bugs.limesurvey.org/view.php?id=19690 (closed)
https://bugs.limesurvey.org/view.php?id=19691 (closed)
https://bugs.limesurvey.org/view.php?id=19692 (closed)
https://bugs.limesurvey.org/view.php?id=19693 (closed)

gabrieljenik

gabrieljenik

2024-08-14 20:38

manager   ~80764

We should create a new branch v8.3 based on DEV.
New PRs should point to that new branch. When all v8.3 is ready we can push to DEV.

What do you think?

tibor.pacalat

tibor.pacalat

2024-08-15 13:23

administrator   ~80768

Last edited: 2024-09-11 12:49

Please update one by one on dev.

tibor.pacalat

tibor.pacalat

2024-09-13 13:44

administrator   ~81016

@gabrieljenik and @DenisChenu can you please point your PRs to master. My bad :(

DenisChenu

DenisChenu

2024-09-13 15:29

developer   ~81019

Can we have this one merged : https://bugs.limesurvey.org/view.php?id=19685 ?

tibor.pacalat

tibor.pacalat

2024-09-13 17:37

administrator   ~81020

Sure @DenisChenu when the PR points to master and I test it.

jweberhofer

jweberhofer

2024-09-19 18:15

reporter   ~81062

I have added https://github.com/LimeSurvey/LimeSurvey/pull/3968 that fixes some NULL issues for me.

jweberhofer

jweberhofer

2024-09-19 18:16

reporter   ~81063

There are some issues with the vendor library mk-j/PHP_XLSXWriter, too. It's author has no activities on https://github.com/mk-j since more then a year. How can that be handled?

gabrieljenik

gabrieljenik

2024-09-26 21:43

manager   ~81121

I this can be closed... right @tibor.pacalat?

tibor.pacalat

tibor.pacalat

2024-09-27 11:51

administrator   ~81123

@gabrieljenik, no it can't. All of the subtickets need to be resolved first.

tibor.pacalat

tibor.pacalat

2024-10-15 09:58

administrator   ~81243

Ok, all tickets have been resolved or closed (because there was no change needed). I will put this ticket to resolved.

Issue History

Date Modified Username Field Change
2024-06-26 17:06 tibor.pacalat New Issue
2024-06-26 17:06 tibor.pacalat Assigned To => gabrieljenik
2024-06-26 17:06 tibor.pacalat Status new => assigned
2024-06-26 17:06 tibor.pacalat Relationship added related to 19487
2024-06-26 17:07 tibor.pacalat Relationship added related to 19550
2024-06-26 17:07 tibor.pacalat Relationship added related to 18802
2024-06-26 17:13 DenisChenu Note Added: 80473
2024-06-26 17:13 DenisChenu Bug heat 0 => 2
2024-06-26 17:18 DenisChenu Note Added: 80476
2024-06-26 17:37 tibor.pacalat Summary Make Limesurvey compatible with php3.8 => Make Limesurvey compatible with php8.3
2024-08-05 16:29 gabrieljenik Note Added: 80739
2024-08-05 16:29 gabrieljenik File Added: 19632.log.txt
2024-08-05 16:29 gabrieljenik Bug heat 2 => 4
2024-08-05 16:29 gabrieljenik Note Added: 80740
2024-08-06 09:32 tibor.pacalat Note Added: 80743
2024-08-06 09:32 tibor.pacalat Bug heat 4 => 6
2024-08-06 14:54 gabrieljenik Note Added: 80750
2024-08-06 15:21 tibor.pacalat Note Added: 80751
2024-08-08 14:19 tibor.pacalat Note Added: 80762
2024-08-14 20:38 gabrieljenik Note Added: 80764
2024-08-15 13:23 tibor.pacalat Note Added: 80768
2024-09-11 12:49 tibor.pacalat Note Edited: 80768
2024-09-12 11:17 DenisChenu Relationship added parent of 19685
2024-09-12 11:17 DenisChenu Relationship added parent of 19686
2024-09-12 11:19 DenisChenu Relationship added parent of 19687
2024-09-12 11:20 DenisChenu Relationship added parent of 19688
2024-09-12 11:21 DenisChenu Relationship added related to 19689
2024-09-12 11:23 DenisChenu Relationship added related to 19690
2024-09-12 11:23 DenisChenu Relationship replaced parent of 19690
2024-09-12 11:25 DenisChenu Relationship added parent of 19691
2024-09-12 11:25 DenisChenu Relationship added parent of 19692
2024-09-12 14:44 Mazi Bug heat 6 => 12
2024-09-12 16:29 DenisChenu Relationship added parent of 19747
2024-09-12 16:29 DenisChenu Relationship deleted parent of 19747
2024-09-13 13:44 tibor.pacalat Note Added: 81016
2024-09-13 15:29 DenisChenu Note Added: 81019
2024-09-13 17:37 tibor.pacalat Note Added: 81020
2024-09-18 15:39 tibor.pacalat Note Edited: 80762
2024-09-18 15:40 tibor.pacalat Note Edited: 80762
2024-09-18 17:07 tibor.pacalat Note Edited: 80762
2024-09-19 18:15 jweberhofer Note Added: 81062
2024-09-19 18:15 jweberhofer Bug heat 12 => 14
2024-09-19 18:16 jweberhofer Note Added: 81063
2024-09-26 21:43 gabrieljenik Note Added: 81121
2024-09-27 11:51 tibor.pacalat Note Added: 81123
2024-09-27 17:11 tibor.pacalat Note Edited: 80762
2024-10-11 14:17 tibor.pacalat Note Edited: 80762
2024-10-15 09:58 tibor.pacalat Note Added: 81243
2024-10-15 09:58 tibor.pacalat Status assigned => resolved
2024-10-15 09:58 tibor.pacalat Resolution open => fixed
2024-10-15 09:58 tibor.pacalat Note Edited: 80762
2024-11-19 18:14 c_schmitz Status resolved => closed