View Issue Details

This bug affects 1 person(s).
 266
IDProjectCategoryView StatusLast Update
19890Bug reportsSecuritypublic2025-02-17 17:57
Reportermferraz Assigned Totibor.pacalat  
PrioritynoneSeverityminor 
Status closedResolutionfixed 
Product Version6.6.x 
Summary19890: The required password lenght is wrong
Description

Hi.

Some users are asked to set an 8-character password when setting a new password, but it is a minimal 12-character requirement.

Steps To Reproduce

Set the password

TagsNo tags attached.
Attached Files
image-2.png (95,775 bytes)   
image-2.png (95,775 bytes)   
Bug heat266
Complete LimeSurvey version number (& build)6.8.2+241203
I will donate to the project if issue is resolvedNo
Browser
Database type & versionPostgreSQL 13
Server OS (if known)Ubuntu
Webserver software & version (if known)Apache
PHP VersionPHP 8.1

Relationships

has duplicate 19954 closedc_schmitz false/confusing message for user about password length for password reset 

Users monitoring this issue

There are no users monitoring this issue.

Activities

tibor.pacalat

tibor.pacalat

2025-02-03 11:42

administrator   ~81940

@mferraz Do you mean on this screen (see screenshot)? If so I can confirm that the feedback up is wrong. It says minimum 8 characters, but this is not true.

mferraz

mferraz

2025-02-04 10:09

reporter   ~81967

Hi.

That's right.

gabrieljenik

gabrieljenik

2025-02-11 14:02

manager   ~82000

https://github.com/LimeSurvey/LimeSurvey/pull/4164

Before the fix, the error message showed all the rules, not just the one which was failing.
That was not very consistent with other parts of the code where password is being set.
Ex: application\controllers\UserManagementController.php :: actionApplyEdit()
Ex: User::ValidateNewPassword()
Now it shows only the rule that is failing.

It is to highlight that using the prior approach would only work for standard rules, not for rules set in the plugin: it is impossible to know the rules set in the plugin. For that there would have to be a new plugin event (or as workaround call the plugin empty password from User::getPasswordHelpText())

As a suggestion, I think the screen should show the rules in the screen it self before a password is submitted, calling the helptext method from the screen rendering.

DenisChenu

DenisChenu

2025-02-12 09:10

developer   ~82008

It is to highlight that using the prior approach would only work for standard rules, not for rules set in the plugin: it is impossible to know the rules set in the plugin. For that there would have to be a new plugin event (or as workaround call the plugin empty password from User::getPasswordHelpText())

Plugin can not set value of checkPasswordStrength ?

Maybe report it as a new issue : my opinion : paswordPlugin can set (or update)

  • checkPasswordStrength string
  • getPasswordHelpText string
LimeBot

LimeBot

2025-02-17 17:57

administrator   ~82044

Fixed in Release 6.10.5+250217

Issue History

Date Modified Username Field Change
2024-12-13 17:14 mferraz New Issue
2024-12-13 17:14 mferraz File Added: image-2.png
2025-02-03 11:42 tibor.pacalat Note Added: 81940
2025-02-03 11:42 tibor.pacalat File Added: Screenshot 2025-02-03 at 11.40.29.png
2025-02-03 11:42 tibor.pacalat Bug heat 250 => 252
2025-02-03 11:42 tibor.pacalat Assigned To => gabrieljenik
2025-02-03 11:42 tibor.pacalat Status new => confirmed
2025-02-04 10:09 mferraz Note Added: 81967
2025-02-04 10:09 mferraz Bug heat 252 => 254
2025-02-06 12:04 tibor.pacalat Relationship added has duplicate 19954
2025-02-06 12:04 tibor.pacalat Bug heat 254 => 260
2025-02-11 14:02 gabrieljenik Status confirmed => ready for code review
2025-02-11 14:02 gabrieljenik Note Added: 82000
2025-02-11 14:02 gabrieljenik Bug heat 260 => 262
2025-02-11 14:06 gabrieljenik Assigned To gabrieljenik => DenisChenu
2025-02-12 09:10 DenisChenu Note Added: 82008
2025-02-12 09:10 DenisChenu Bug heat 262 => 264
2025-02-12 09:10 DenisChenu Assigned To DenisChenu => tibor.pacalat
2025-02-12 09:10 DenisChenu Status ready for code review => ready for testing
2025-02-12 17:42 tibor.pacalat Status ready for testing => resolved
2025-02-12 17:42 tibor.pacalat Resolution open => fixed
2025-02-17 17:57 LimeBot Note Added: 82044
2025-02-17 17:57 LimeBot Status resolved => closed
2025-02-17 17:57 LimeBot Bug heat 264 => 266