View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
16498 | Bug reports | Theme editor | public | 2020-07-15 15:41 | 2020-07-30 15:11 |
Reporter | Mazi | Assigned To | |||
Priority | none | Severity | crash | ||
Status | closed | Resolution | fixed | ||
Product Version | 3.22.26 | ||||
Summary | 16498: Can't run survey with child theme because of enheritance problems. | ||||
Description | When running the small attached test survey with the fruity theme, everything is working fine. If I extend fruity and add another theme option to the options.twig and config.xml file, the same survey is broken when switching to the new theme. So my guess is that either I am too stupid to add a custom setting or something with the inheritance feature is wrong. | ||||
Steps To Reproduce |
| ||||
Additional Information | options.twig sample code: config.xml new setting: Error message: /var/www/vhosts/my-survey.host/fma.my-survey.host/ls/application/core/LSETwigViewRenderer.php(512) 500 $showxquestions = Yii::app()->getConfig('showxquestions'); | ||||
Tags | No tags attached. | ||||
Bug heat | 10 | ||||
Complete LimeSurvey version number (& build) | Version 3.22.26+200714 | ||||
I will donate to the project if issue is resolved | No | ||||
Browser | Chrome | ||||
Database type & version | MySQL 5 | ||||
Server OS (if known) | Ubuntu 18 | ||||
Webserver software & version (if known) | Apache | ||||
PHP Version | 7.3 | ||||
related to | 16508 | closed | gabrieljenik | Can't run survey with child theme because of enheritance problems. |
Added theme and sample survey. |
|
@gabrieljenik, this is the issue we talked about. |
|
From what we saw the problem comes with comments in the config.xml, in the options area. When these empty objects are parsed through the PHP code, it expects When using the survey options (no inheritance), the options saved on the DB come from the twig, so no empty nodes are saved. Suggested steps for solution: Comments? |
|
I already see issue with XML comments set as null nod in DB. 1+2 seems great :) We have an issue about empty node in QuestinTheme |
|
Tested the issue by pulling the PR but I can still see the issue. @gabrieljenik can confirm on this ? |
|
Please refer the attachment for more details |
|
My opinion : current pull request didn't fix already broken DB, only new copy Must reset theme ? |
|
Tested the issue before pulling the PR, Issue exist. Tested the issue after pulling the PR, working as expected. Please refer the attachment for more details Tested also by enabling debug mode |
|
Fix committed to 3.x-LTS branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=30305 |
|
Fixed in Release 3.22.28+200728 |
|
Fixed in Release 3.22.28+200728 |
|
LimeSurvey: 3.x-LTS 00f6b275 2020-07-21 02:14 Details Diff |
Fixed issue 16498: Can't run survey with child theme because of enheritance problems. 1- Removed comments after loading config.xml. 2 - Had empty nodes to be saved in DB as empty strings. |
Affected Issues 16498 |
|
mod - application/models/TemplateConfig.php | Diff File | ||
mod - application/models/TemplateManifest.php | Diff File | ||
LimeSurvey: 3.x-LTS bfb947aa 2020-07-23 20:57 Committer: GitHub Details Diff |
Merge pull request #1492 from gabrieljenik/bug/16498-Cant-run-survey-with-child-theme-because-of-enheritance-problems Fixed issue 16498: Can't run survey with child theme because of enheritance problems. |
Affected Issues 16498 |
|
mod - application/models/TemplateConfig.php | Diff File | ||
mod - application/models/TemplateManifest.php | Diff File |
Date Modified | Username | Field | Change |
---|---|---|---|
2020-07-15 15:41 | Mazi | New Issue | |
2020-07-15 15:43 | Mazi | Note Added: 58956 | |
2020-07-15 15:43 | Mazi | File Added: limesurvey_survey_671144.lss | |
2020-07-15 15:43 | Mazi | File Added: fma_fruity.zip | |
2020-07-15 15:43 | Mazi | Note Added: 58957 | |
2020-07-15 20:23 | gabrieljenik | Note Added: 58962 | |
2020-07-16 09:36 | DenisChenu | Note Added: 58967 | |
2020-07-21 00:10 | gabrieljenik | Issue cloned: 16508 | |
2020-07-21 00:10 | gabrieljenik | Relationship added | related to 16508 |
2020-07-21 00:15 | gabrieljenik | Note Added: 59005 | |
2020-07-21 17:32 |
|
Note Added: 59022 | |
2020-07-21 17:42 |
|
Note Added: 59024 | |
2020-07-21 17:42 |
|
File Added: 16498_ChildTheme_Enheritance issue.png | |
2020-07-21 17:47 | DenisChenu | Note Added: 59025 | |
2020-07-22 16:29 |
|
Note Added: 59045 | |
2020-07-22 16:29 |
|
File Added: 16498_ChildTheme_Enheritance.png | |
2020-07-22 17:27 |
|
Status | new => confirmed |
2020-07-22 17:27 |
|
Zoho Sprints | => |Yes| |
2020-07-22 17:27 |
|
Zoho Sprints ID | => 14469000000188025 |
2020-07-23 18:58 | LimeBot | Changeset attached | => LimeSurvey 3.x-LTS bfb947aa |
2020-07-23 18:58 | gabrieljenik | Changeset attached | => LimeSurvey 3.x-LTS 00f6b275 |
2020-07-23 18:58 | gabrieljenik | Note Added: 59064 | |
2020-07-27 10:53 | lime_release_bot | Zoho Sprints | Yes => |Yes| |
2020-07-27 10:53 | lime_release_bot | Note Added: 59095 | |
2020-07-27 10:53 | lime_release_bot | Status | confirmed => closed |
2020-07-27 10:53 | lime_release_bot | Resolution | open => fixed |
2020-07-29 16:18 |
|
Zoho Sprints | Yes => |Yes| |
2020-07-29 16:18 |
|
Status | closed => resolved |
2020-07-30 15:11 | lime_release_bot | Zoho Sprints | Yes => |Yes| |
2020-07-30 15:11 | lime_release_bot | Note Added: 59205 | |
2020-07-30 15:11 | lime_release_bot | Status | resolved => closed |