View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
16508 | Bug reports | Theme editor | public | 2020-07-21 00:10 | 2020-08-12 10:10 |
Reporter | gabrieljenik | Assigned To | gabrieljenik | ||
Priority | none | Severity | crash | ||
Status | closed | Resolution | fixed | ||
Product Version | 4.3.4 | ||||
Summary | 16508: Can't run survey with child theme because of enheritance problems. | ||||
Description | Cloned from 16498. This one applies to v4 When running the small attached test survey with the fruity theme, everything is working fine. If I extend fruity and add another theme option to the options.twig and config.xml file, the same survey is broken when switching to the new theme. So my guess is that either I am too stupid to add a custom setting or something with the inheritance feature is wrong. | ||||
Steps To Reproduce |
| ||||
Additional Information | options.twig sample code: config.xml new setting: Error message: /var/www/vhosts/my-survey.host/fma.my-survey.host/ls/application/core/LSETwigViewRenderer.php(512) 500 $showxquestions = Yii::app()->getConfig('showxquestions'); | ||||
Tags | No tags attached. | ||||
Bug heat | 6 | ||||
Complete LimeSurvey version number (& build) | Version 4.3.0 | ||||
I will donate to the project if issue is resolved | No | ||||
Browser | Chrome | ||||
Database type & version | MySQL 5 | ||||
Server OS (if known) | Ubuntu 18 | ||||
Webserver software & version (if known) | Apache | ||||
PHP Version | 7.3 | ||||
related to | 16498 | closed | Can't run survey with child theme because of enheritance problems. |
I was not able to replicate this issue in the latest master Version(4.3.5). |
|
Although codebase is similar, I have found this line on master, which I guess it is not on LTS. It is on Master That's why the issue happened on LTS but not on Master. Should we apply the same changes we applied on LTS to master? |
|
Although issue was not reproducible here, we port some of the fixes added on LTS |
|
Code is been reviewed by Jessica, working fine |
|
Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=30362 |
|
Fixed in Release 4.3.10+200812 |
|
LimeSurvey: master babbddb1 2020-08-10 17:36 Committer: GitHub Details Diff |
Fixed issue 16508: Can't run survey with child theme because of enheritance problems. (#1523) 1- Removed xml comments after loading config.xml. 2 - Had empty nodes to be saved in DB as empty strings. |
Affected Issues 16508 |
|
mod - application/models/TemplateConfig.php | Diff File | ||
mod - application/models/TemplateManifest.php | Diff File |
Date Modified | Username | Field | Change |
---|---|---|---|
2020-07-21 00:10 | gabrieljenik | New Issue | |
2020-07-21 00:10 | gabrieljenik | Issue generated from: 16498 | |
2020-07-21 00:10 | gabrieljenik | Relationship added | related to 16498 |
2020-07-21 16:42 |
|
Note Added: 59019 | |
2020-07-22 16:10 | gabrieljenik | Note Added: 59043 | |
2020-07-22 16:10 | gabrieljenik | File Added: image.png | |
2020-07-30 00:35 | gabrieljenik | Note Added: 59189 | |
2020-07-30 00:46 | gabrieljenik | Note Edited: 59189 | |
2020-08-04 17:34 |
|
Note Added: 59297 | |
2020-08-10 15:49 | gabrieljenik | Changeset attached | => LimeSurvey master babbddb1 |
2020-08-10 15:49 | gabrieljenik | Note Added: 59388 | |
2020-08-10 15:49 | gabrieljenik | Assigned To | => gabrieljenik |
2020-08-10 15:49 | gabrieljenik | Resolution | open => fixed |
2020-08-12 10:10 | lime_release_bot | Note Added: 59427 | |
2020-08-12 10:10 | lime_release_bot | Status | new => closed |